Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

improve sub URI deployment / docs / other tweaks #64

Open
wants to merge 499 commits into
base: master
Choose a base branch
from

Conversation

ramcq
Copy link

@ramcq ramcq commented Apr 26, 2011

Nothing groundbreaking here, just some tweaks I did to get up and running this weekend. Thought I should share the sub URI fixes and update the documentation as it took me a while to coax into life. Hopefully it doesn't break the non sub-URI case... :)

The changes to graph.js are fairly pointless but they allow a simple place in the code for me to hack in appearance changes depending on the graph being drawn. I've got a current monitoring device hooked up to collectd (http://thread.gmane.org/gmane.comp.monitoring.collectd/4479) where the graphs really make a lot more visual sense when the readings are stacked:

    if (this.options.plugin.test(/^currentcost-/)) {
      options.chart.defaultSeriesType = 'area';
      options.colors = ['#F08080','#EEE8AA','#ADD8E6'];
    }

I think a lot of other data types like memory, CPU, networking, etc are amenable to stacked graphing too so if you've got some good ideas how to match/implement cleanly I'd be happy to have a go at a patch.

auxesis and others added 28 commits January 25, 2011 15:57
Conflicts:
	visage-app.gemspec
After testing/debugging deploying using Passenger in a sub URI, adding these
link_to invocations seems to make things work.
Gives an opportunity to monkey around with graph settings before the graph is
drawn.
Disable shadows, and set up area graphs with thin grey lines & stacking.
Talk a little more explicitly about sub URI configuration as it took me a while
to dig through the Passenger documentation and find the right buttons to push.
Be clearer about user permissions as the internet was full of terrible advice.
Suggest configuration is stored in /var/local which is reserved for non-package
managed software.
@auxesis
Copy link
Owner

auxesis commented Apr 29, 2011

This looks pretty great!

I'm of two minds about the specific colour schemes though. On one hand, it makes the colours inconsistent with the rest of the rendered graphs, and on the other they look pretty sweet. :-)

What do you think?

It's a bit of an ask, but have you tested these colours for people with trichromacy colour blindness? Totally ok if you haven't, I'm just curious about if these colours are any better than the Visage/Highcharts defaults.

@stewartadam
Copy link

Please commit the changes regarding sub URIs... On many machines I don't have a spare IP / domain to dedicate to a VirtualHost and need to use sub URIs.

Note that since these changes a few other files need to be changed, namely the 'data' callback location in the JavaScript files is hardcoded and doesn't get prefixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants