Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags so that no prompting is possible #188

Merged
merged 4 commits into from
Aug 19, 2022
Merged

Add flags so that no prompting is possible #188

merged 4 commits into from
Aug 19, 2022

Conversation

holisticode
Copy link
Contributor

@holisticode holisticode commented Aug 10, 2022 •
edited
Loading

Closes #136

dasconnor
dasconnor reviewed Aug 16, 2022
View reviewed changes
Copy link
Contributor

@dasconnor dasconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can approve this after we finalize the decision around network flags

cmd/subnetcmd/join.go Outdated Show resolved Hide resolved
cmd/subnetcmd/join.go Show resolved Hide resolved
@holisticode holisticode mentioned this pull request Aug 19, 2022
Merged
@dasconnor dasconnor merged commit 2bc88ea into main Aug 19, 2022
@michaelkaplan13 michaelkaplan13 deleted the 136-join-flags branch September 25, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasconnor dasconnor dasconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flags to subnet join
2 participants
@holisticode @dasconnor