Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the keystore DoS vulnerability #196

Closed
wants to merge 1 commit into from

Conversation

Shashank-In
Copy link
Contributor

@Shashank-In
Copy link
Contributor Author

Test cases are failing because of the char limit I added.

--- FAIL: TestServiceCreateUser (0.00s)
652    service_test.go:47: CreateUser call rejected due to username or password exceeding maximum length of 25 chars
653--- FAIL: TestServiceCreateDuplicate (0.00s)
654    service_test.go:150: CreateUser call rejected due to username or password exceeding maximum length of 25 chars
655--- FAIL: TestServiceUseBlockchainDB (0.00s)
656    service_test.go:190: CreateUser call rejected due to username or password exceeding maximum length of 25 chars
657--- FAIL: TestServiceExportImport (0.00s)
658    service_test.go:230: CreateUser call rejected due to username or password exceeding maximum length of 25 chars

@swdee
Copy link
Contributor

swdee commented Jun 1, 2020

Changing it to a maximum length of 25 would prevent a large group of people from using their email address as a username which is quite commonly used.

@Shashank-In
Copy link
Contributor Author

Closing as this is not the correct fix

@Shashank-In Shashank-In closed this Jun 2, 2020
@Shashank-In Shashank-In deleted the patch-1 branch June 2, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants