Restructured fee calculator API #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
commented
Jun 24, 2024
abi87
commented
Jun 24, 2024
abi87
commented
Jun 24, 2024
abi87
requested review from
danlaine,
dhrubabasu and
StephenButtolph
as code owners
marun
reviewed
Jun 25, 2024
joshua-kim
reviewed
Jul 2, 2024
joshua-kim
reviewed
Jul 2, 2024
joshua-kim
reviewed
Jul 2, 2024
abi87
force-pushed
the
p-chain_improved_fee_calculator_structure
branch
from
7350e0a
to
7f5952e
Compare
abi87
force-pushed
the
p-chain_improved_fee_calculator_structure
branch
from
7f5952e
to
fc95471
Compare
marun
approved these changes
Jul 11, 2024
StephenButtolph
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
platformvm/txs/feepackage will be extended to include a dynamic fee calculator. This PR restructure the fee calculator package and APIs to prepare for the changesHow this works
fee.CalculatorAPIstruct, to be used by clients and afee.backendinterface to be implemented by calculators (currentlystaticCalculator, soondynamicCalculatoras well)CalculateFeeattribute to pick only unsignedTx and credentials as parameters. Currently chainTime is a parameters as well, but that won't be needed for the dynamic calculator, hence it has been moved to the constructorHow this was tested
CI