Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics API missing #39

Closed
Sanghren opened this issue Jun 8, 2020 · 3 comments
Closed

Metrics API missing #39

Sanghren opened this issue Jun 8, 2020 · 3 comments
Assignees

Comments

@Sanghren
Copy link
Contributor

Sanghren commented Jun 8, 2020

I also noticed that the Metrics API is not present in Slopes . (https://docs.ava.network/v1.0/en/api/metrics/)

Gecko produce the Metrics as a 'Prometheus compatible metrics' .

I propose that we create an endpoint that return the metrics either "raw" (prometheus style) or as a JSON (I'm using this in Snowboard : https://www.npmjs.com/package/parse-prometheus-text-format) .

What do you think ?

@collincusce
Copy link
Contributor

Thanks! Assigned to @cgcardona

@cgcardona
Copy link
Contributor

Circling back to this—it seems like the best option for now is to just return "raw" (prometheus style) . Later we can reevaluate adding a 3rd party lib and/or parsing and formatting them ourselves.

@cgcardona
Copy link
Contributor

Resolved in #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants