Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implement importKey , exportKey for platformAPI #38

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

Sanghren
Copy link
Contributor

@Sanghren Sanghren commented Jun 8, 2020

This PR contains :

@Sanghren
Copy link
Contributor Author

Sanghren commented Jun 8, 2020

Need to be sure that the code I implemented works, but it's too late for me start a new Gecko node with 0.5.3 today, that will be for tomorrow !

@Sanghren
Copy link
Contributor Author

Sanghren commented Jun 9, 2020

Tested on my local, I think it's ready for review now

@Sanghren Sanghren marked this pull request as ready for review June 9, 2020 09:20
@Sanghren
Copy link
Contributor Author

Sanghren commented Jun 9, 2020

Tested on my local, I think it's ready for review now

Copy link
Contributor

@collincusce collincusce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! However, your linter went ham on the code. Let's turn that off and stay stylistically in-line with the codebase.

@Sanghren
Copy link
Contributor Author

@collincusce oups indeed, I think I reverted them all now

@collincusce collincusce merged commit 22ead22 into ava-labs:master Jun 12, 2020
@collincusce
Copy link
Contributor

Looks good, I'm merging these into the user_changes branch to run all three with tests at the same time before moving to master.

@collincusce
Copy link
Contributor

Orrr not because I forgot to rebase. Lovely. Well it worked out this time.

@Sanghren Sanghren deleted the fix/add_missing_platform_calls branch June 30, 2020 09:07
dfenstermaker pushed a commit that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants