-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Implement importKey
, exportKey
for platformAPI
#38
fix: Implement importKey
, exportKey
for platformAPI
#38
Conversation
Need to be sure that the code I implemented works, but it's too late for me start a new Gecko node with 0.5.3 today, that will be for tomorrow ! |
Tested on my local, I think it's ready for review now |
Tested on my local, I think it's ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! However, your linter went ham on the code. Let's turn that off and stay stylistically in-line with the codebase.
@collincusce oups indeed, I think I reverted them all now |
Looks good, I'm merging these into the user_changes branch to run all three with tests at the same time before moving to master. |
Orrr not because I forgot to rebase. Lovely. Well it worked out this time. |
This PR contains :
exportKey
function in PlatformAPI . (https://docs.ava.network/v1.0/en/api/platform/#platformexportkey)importKey
function in PlatformAPI . (https://docs.ava.network/v1.0/en/api/platform/#platformimportkey)