Revert PR 249 #252
Merged
Revert PR 249 #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holisticode
requested review from
ceyonur,
darioush,
patrick-ogrady and
aaronbuchwald
as code owners
holisticode
force-pushed
the
revert-PR-249
branch
from
5564711
to
9f7a7f6
Compare
|
Can we get it merged asap? |
ceyonur
approved these changes
Sep 6, 2022
darioush
approved these changes
Sep 7, 2022
aaronbuchwald
approved these changes
Sep 19, 2022
|
Just FYI we could consider nixing the shared-timer[1] logic which is now back as part of avalanchego. We should come up with a general plan for replacement as the it is defined as deprecated but just a thought before this merges. |
Good callout, adding an issue to track this here. We should be able to remove all timeouts from the block building logic. We have already gotten rid of the two staged timer in coreth, which will be migrated to subnet-evm soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.