Bump avalanchego v1.9.3 and Coreth Migration through v0.11.3 #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha-ctrl
approved these changes
Nov 23, 2022
aaronbuchwald
changed the title
anusha-ctrl
reviewed
Nov 23, 2022
anusha-ctrl
reviewed
Nov 23, 2022
anusha-ctrl
approved these changes
Nov 23, 2022
* sync auto-formatted changes * add coreth version txt * add latest coreth version
darioush
approved these changes
Nov 28, 2022
| @@ -50,7 +50,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| targetTxsSize = 232 * units.KiB | |||
| targetTxsSize = 1800 * units.KiB | |||
There was a problem hiding this comment.
what is the reason to use 1800 vs 1792 in coreth?
There was a problem hiding this comment.
There are no atomic transactions here, so I thought it made sense to add a little more to the soft cap.
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #368