Test add additional fee amount (Part 1) #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwen917
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
geoff-vball,
bernard-avalabs and
feuGeneA
as code owners
gwen917
changed the title
cam-schultz
approved these changes
Nov 6, 2023
tests/add_fee_amount.go
Outdated
| addFeeAmount(&network.LocalNetwork{}) | ||
| } | ||
|
|
||
| func addFeeAmount(network network.Network) { |
There was a problem hiding this comment.
Let's export this function so that a separate application can call it to test against Fuji
| network.RelayMessage(ctx, sendCrossChainMsgReceipt.BlockHash, sendCrossChainMsgReceipt.BlockNumber, subnetAInfo, subnetBInfo) | ||
|
|
||
| // Check Teleporter message received on the destination | ||
| delivered, err := subnetBTeleporterMessenger.MessageReceived(&bind.CallOpts{}, subnetAInfo.BlockchainID, messageID) |
There was a problem hiding this comment.
This is a great way to call the contracts, I'll update my own PRs to use this interface
tests/add_fee_amount.go
Outdated
| // check the fee amount | ||
| amount, err := subnetATeleporterMessenger.CheckRelayerRewardAmount(&bind.CallOpts{}, fundedAddress, mockTokenAddress) | ||
| Expect(err).Should(BeNil()) | ||
| Expect(amount).Should(Equal(big.NewInt(1))) |
There was a problem hiding this comment.
Can you add variables initialFeeAmount and adjustedFeeAmount and check against those rather than checking against the number on its own?
cam-schultz
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements the following test cases from #94
How this works
See above
How this was tested
New E2E test cases
How is this documented