Test relay altered message #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwen917
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
geoff-vball,
bernard-avalabs and
feuGeneA
as code owners
cam-schultz
approved these changes
Nov 13, 2023
bernard-avalabs
approved these changes
Nov 14, 2023
tests/utils/utils.go
Outdated
| Expect(modifiedMessage[:]).ShouldNot(Equal(signedMessage.Payload[:])) | ||
| signedMessage.Payload = modifiedMessage | ||
|
|
||
| signedMessage.Initialize() |
There was a problem hiding this comment.
Should we consider a related test where the signature is from the original payload? Perhaps testing incorrect signatures is already covered in a different test case.
cam-schultz
reviewed
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements the following test cases from #94
How this works
See above
How this was tested
New E2E test cases
How is this documented