Remove bash integration tests #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
gwen917,
geoff-vball and
bernard-avalabs
as code owners
geoff-vball
reviewed
Nov 30, 2023
6 tasks
geoff-vball
previously approved these changes
Dec 1, 2023
| @@ -9,51 +9,6 @@ on: | |||
| - "*" | |||
|
|
|||
| jobs: | |||
| teleporter-integration-test: | |||
There was a problem hiding this comment.
Can we rename this file to be a little more specific now that it only contains one type of test?
There was a problem hiding this comment.
Can we combine e2e.yml into here?
There was a problem hiding this comment.
Yeah that makes more sense!
There was a problem hiding this comment.
Put everything in test.yml
geoff-vball
previously approved these changes
Dec 5, 2023
michaelkaplan13
previously approved these changes
Dec 5, 2023
cam-schultz
dismissed stale reviews from michaelkaplan13 and geoff-vball
via
1b9dead
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam and
geoff-vball
geoff-vball
approved these changes
Dec 5, 2023
michaelkaplan13
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes the bash integration test setup, now that all of those integration tests have been implemented in the Ginkgo framework.
Fixes #27
How this works
Removes integration test scripts, test runner docker compose files, and the integration test CI job.
How this was tested
CI, verified that
run.shstill works as expectedHow is this documented
Removed all references to
test.shfrom the docs, and removed some related documentation bloat.