Realistic get ip method - faster locks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @johnathanhowell and welcome to Go. Locks in go are performing better on small code-blocks than wrapped to a bigger one. At these changes, - I changed the `sync.Mutex` to `sync.RWMutex` in order to lock/unlock per-read or read & write when ever we need it. - I also introduced a more realistic method to get an IP, even behind a regular proxy. - I commented the `mu` variable in order to be easy to understand what it locks/unlocks (it's a good practice to comment the lockers following by the variable(s) )
|
Thanks for the pull request! |
|
You're welcome, continue this, it has many potentials and more features that we can adapt on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @johnathanhowell and welcome to Go.
Locks in go are performing better on small code-blocks than wrapped to a bigger one.
At these changes,
sync.Mutextosync.RWMutexin order to lock/unlock per-read or read & write when ever we need it.muvariable in order to be easy to understand what it locks/unlocks (it's a good practice to comment the lockers following by the variable(s) )