-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@Property
methods now implicitly override fields
#217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbygrave
reviewed
Mar 7, 2024
jsonb-generator/src/test/java/io/avaje/jsonb/generator/models/valid/OptionalAccess.java
Outdated
Show resolved
Hide resolved
I'll take a look this night to see if I can help add support for views, we might also want to consider OptionalInt, OptionaLong, OptionalDouble |
SentryMan
changed the title
Support Optional Accessors
Mar 10, 2024
@Property
methods can now override fields
SentryMan
changed the title
Mar 10, 2024
@Property
methods can now override fields@Property
methods now implicitly override fields
found another way to do it. |
Yeah, I'm good with this. @rbygrave please review when you get time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Property
method targeting the same field is located (the getter method will serialize instead)Now this:
will generate like this:
part of #216