Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing implementations of test.serial.failing.{only|skip} #1898

Closed
novemberborn opened this issue Aug 12, 2018 · 0 comments · Fixed by #1914
Closed

Add missing implementations of test.serial.failing.{only|skip} #1898

novemberborn opened this issue Aug 12, 2018 · 0 comments · Fixed by #1914
Labels
bug current functionality does not work as desired good for beginner help wanted
Milestone
1.0

Comments

@novemberborn
Copy link
Member

As discovered by @godu we're missing implementations of test.serial.failing.only() and test.serial.failing.skip(). They need to be declared in https://github.com/avajs/ava/blob/76a8ce8ff44ca7df1e9767b8170c890ef8dbd9a9/lib/create-chain.js#L61:L89.

This is a great issue to tackle for newcomers. I don't think we need to add tests for this either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug current functionality does not work as desired good for beginner help wanted
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Add test.serial.failing.{only|skip} implementations (#1898)
1 participant
@novemberborn