-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop on first failed assertion #220
Comments
jamestalmage
added a commit
to jamestalmage/ava
that referenced
this issue
Nov 23, 2015
jamestalmage
added a commit
to jamestalmage/ava
that referenced
this issue
Nov 23, 2015
sindresorhus
pushed a commit
that referenced
this issue
Nov 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that test cases are not stopped when an assertion fails. To be exact, they are stopped asynchronously. Here is an example:
The error I'd expect to see is "1 !== 2" while the actual error I get is "cannot read property 'name' of undefined" because execution is not stopped on the failed assertion (on the line above).
Is there a reason why
Test#exit()
is called asynchronously (byTest#_assert()
) rather than synchronously (which is the case for errors thrown outside assertions)?The text was updated successfully, but these errors were encountered: