Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used package micromatch not in package.json #2484

Closed
hyperupcall opened this issue May 8, 2020 · 2 comments · Fixed by #2485
Closed

used package micromatch not in package.json #2484

hyperupcall opened this issue May 8, 2020 · 2 comments · Fixed by #2485
Assignees
Labels
bug current functionality does not work as desired

Comments

@hyperupcall
Copy link

hyperupcall commented May 8, 2020

  • What you're trying to do
    Execute ava binary

  • What happened
    Ava and crashes because it 'Cannot find module micromatch' (see photo below)

  • What you expected to happen
    No crash to occur

  • Steps

// package.json
{
  "scripts": {
    "test": "ava"
  },
  "devDependencies": {
    "ava": "^3.8.1"
  }
}
// test/test.index.js
import test from 'ava'
// or const test = require('test')
pnpm i
yarn test

here is the exact error i've received when executing yarn test after downloading ava with either pnpm or yarn 2

image

since micromatch does appear to be used, i can create a pr to add micromatch (latest version 3.0.4, published 3 years ago), to the package.json if you wish.

@novemberborn
Copy link
Member

Oh good find. I would have expected a linting rule to catch that, actually.

No need to add the dependency, but I'll change the offending code to use picomatch instead.

@novemberborn novemberborn added bug current functionality does not work as desired and removed needs triage labels May 8, 2020
@novemberborn novemberborn self-assigned this May 8, 2020
novemberborn added a commit that referenced this issue May 8, 2020
novemberborn added a commit that referenced this issue May 8, 2020
@novemberborn
Copy link
Member

This should be fixed in 3.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug current functionality does not work as desired
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants