Add always to TS definition
#1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Node 6 failing tests are fixed in 20ab39d so they don't apply to this PR. |
|
@ivogabe any chance you could rebase this? Changes look good otherwise. |
|
Yes, rebased |
|
Thank you! :) |
tjbenton
added a commit
to tjbenton/ava-spec
that referenced
this pull request
Oct 5, 2016
This was added in pr avajs/ava#1025
sheerun
pushed a commit
to sheerun/ava-spec
that referenced
this pull request
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difficulty was that
test.alwaysshould be disallowed, buttest.always.aftershould work. Sotest.alwaysshould not have a call signature, but it should have members. I wrote some code for that, but that wasn't working. (We need tests for these definitions.) This PR fixes that.// @SamVerschueren @sindresorhus