Fix typo in t.notThrows example
#1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
changed the title
t.notThrows examplet.notThrows example
|
You're right. Must have been a copy-paste mistake. Thanks :) |
kevva
pushed a commit
that referenced
this pull request
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial documentation fix proposal. I think there is a typo in the example for
t.notThrows. The test name is "rejects" but shouldn't a test with anotThrowsassertion be checking that the promise under test resolves instead of rejects? It's confusing when compared with the example forthrowsdirectly above that has a test named "rejects" as well.Cheers and thanks for Ava!