Ignore possible test files under node_modules folder. Fixes #226.

[sotojuan]

As noted in #226, this pull request does two things:

• Add !node_modules to the array https://github.com/sindresorhus/ava/blob/master/cli.js#L203, so that it ignores the folder when ava is ran with no arguments.
• Filter out any matched file that has the string node_modules in it. This works in case the user does something like ava **, which is rare but can happen.

Perhaps there's a more efficient way to do this, but I have tested this in various cases and it works, though I haven't been able to write a proper test for it.

Thanks and let me know if there's anything I can improve on.

[jamestalmage]

This is code is actually before matched files are found.

At this point, files is not an actually a list of files, but a list of glob strings (like "**/*-test.js).

You may be seeing results on your machine here because your operating system is automatically expanding glob strings for you (I believe that is the case on OSX, but not on Windows).

[jamestalmage]

You are on the right track. You need to expand on this using my comments from above.

You should also try to create a test or two. This will likely involve adding some files to the test\fixture folder. Look at some of the tests in test/cli.js for inspiration, and get creative from there.

A good way to verify you have written an effective test is to get rid of your changes to the production code (keep your tests in place). Your new tests should fail without your changes (otherwise what was the point?!), then add back in your changes and verify your changes to the production code take you from failing tests to passing tests.

Done this way, everybody can understand the need for the new code you propose, and your tests become a way of documenting the importance of your PR.

[sindresorhus]

I think we can use '!**/node_modules', to match node_modules at any level and not having to do the filtering below.

[sotojuan]

Wouldn't that only work if the user runs ava with no arguments? When you specify files like in my test or have some sort of custom match (which was the source of this issue), it fails (just tested it).

[sindresorhus]

@sotojuan With how this is currently implemented, yes, but it would work if you instead just always pushed it as the last item to the files array before passing it to globby.

[sotojuan]

Thanks, !**/node_modules/** seems to work best if pushed before passing the files to globby.

[sindresorhus]

@sotojuan That's what I said ;)

[sotojuan]

Ha, I meant adding the extra /** at the end made it work!

[sindresorhus]

Right, yeah.

[jamestalmage]

👍

[sindresorhus]

Landed. Very nice work @sotojuan ;)