Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TypeScript recipe for ESM and ts-node usage #2701

Merged
merged 7 commits into from
Mar 11, 2021
Merged

Improve TypeScript recipe for ESM and ts-node usage #2701

merged 7 commits into from
Mar 11, 2021

Conversation

mesqueeb
Copy link
Contributor

@mesqueeb mesqueeb commented Mar 3, 2021

No description provided.

@sindresorhus
Copy link
Member

I pushed some updates. Please don't force push over them.

@sindresorhus sindresorhus changed the title docs: improve docs for packages with type "module" Improve docs for packages with type "module" Mar 6, 2021
novemberborn
novemberborn reviewed Mar 7, 2021
View reviewed changes
docs/recipes/typescript.md Outdated Show resolved Hide resolved
docs/recipes/typescript.md Outdated Show resolved Hide resolved
@novemberborn
Copy link
Member

Thanks for doing this @mesqueeb!

mesqueeb and others added 2 commits March 8, 2021 10:30
@mesqueeb @novemberborn
Change ESNext to ES2020
aa6eb4b 
Co-authored-by: Mark Wubben <mark@novemberborn.net>
@mesqueeb @novemberborn
refactor: make config shorter
81628b4 
Co-authored-by: Mark Wubben <mark@novemberborn.net>
@mesqueeb
Copy link
Contributor Author

mesqueeb commented Mar 8, 2021 •
edited by novemberborn
Loading

@novemberborn thanks! tested & updated your suggestions, ready for review

  • We'd still need a link inside ESM documentation to the TS documentation. But I'm not sure how to phrase that, so can you add that?

@novemberborn novemberborn changed the title Improve docs for packages with type "module" Improve TypeScript recipe for ESM and ts-node usage Mar 11, 2021
@novemberborn novemberborn merged commit a079152 into avajs:main Mar 11, 2021
@novemberborn
Copy link
Member

Thanks @mesqueeb!

@mesqueeb mesqueeb deleted the patch-1 branch March 11, 2021 14:05
@woss woss mentioned this pull request Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novemberborn novemberborn Awaiting requested review from novemberborn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mesqueeb @sindresorhus @novemberborn