Warn when unsupported ava.config.json files are encountered

[razor-x]

See #2957 (comment)

[novemberborn]

Thanks for this @razor-x. ava.config.json files have actually never worked, it's not a v4 thing.

I'm thinking we shouldn't print to the console in load-config itself. Perhaps we could return an array of existing ava.config.json paths that were encountered while loading a configuration file, and then do the logging from lib/cli.js?

[razor-x]

🤦🏻 🤦🏻 That's actually hilarious. I'm pretty sure what happened is there are so many tools that have the pattern of putting configs in package.json or tool.json or tool.js I must have just assume AVA was the same way as some point in the past.

Anyway, I agree about not logging from this file. Instead of changing the return signature though, how about passing a callback onUnsupportedConfigPath as an argument and we can pass the logging behavior in from the caller? This would even let me add a test for the callback.

[novemberborn]

Returning it makes it easier to print a nice list of encountered files, that's harder to do with a callback.

[razor-x]

I looked at updating the return value, but that seemed kinda stressful as it's a breaking change for that function and would require updating its usage in all tests and other files. I ended up opting for the callback instead since it's a backwards compatible change. Hopefully this is ok with you. It still produces a nice list since it calls the function once with an array.

I ran a quick local test on the cli to check the warning. This is what it looks like.

[novemberborn]

Cheers @razor-x. I haven't had a chance to look at this yet though.

[razor-x]

No worries. I fixed the tests.

[novemberborn]

@razor-x could you allow me to push to your branch? I've got some commits ready that make this return the unsupported files rather than using the callback but I don't seem to be able to push them to the PR.

[razor-x]

@razor-x could you allow me to push to your branch? I've got some commits ready that make this return the unsupported files rather than using the callback but I don't seem to be able to push them to the PR.

Done. Looks like GH does not support that option for org-owned forks, so I just added you to repo.

[novemberborn]

@razor-x it should be this checkbox on the right: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

[razor-x]

[novemberborn]

Strange, it's normally not an issue.

[novemberborn]

@razor-x what do you think of the changes?

[razor-x]

Strange, it's normally not an issue.

I think it's this: isaacs/github#1681 I got into the habit of putting all my forks on a separate org so they don't clutter up my main account.

@razor-x what do you think of the changes?

All good, thanks.

[novemberborn]

Lovely, thanks @razor-x!