Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect process.exit() called from tests #3080

Merged
merged 13 commits into from
Sep 4, 2022
Merged

Detect process.exit() called from tests #3080

merged 13 commits into from
Sep 4, 2022

Conversation

gibson042
Copy link
Contributor

Fixes #861

novemberborn
novemberborn reviewed Aug 13, 2022
View reviewed changes
Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

lib/worker/base.js Outdated Show resolved Hide resolved
lib/worker/base.js Outdated Show resolved Hide resolved
@novemberborn
Copy link
Member

@gibson042 I should have some time this week to help get this over the line.

@novemberborn
Copy link
Member

@gibson042 thanks for 96ff6ef (#3080)! Let's see if it improves things.

I've pushed several updates, please let me know what you think.

@gibson042
Copy link
Contributor Author

@novemberborn The updates look good to me. My only further change was to rename the generic proxyApply to handleProcessExit.

@novemberborn novemberborn changed the title Override process.exit in tests Detect process.exit() called from tests Sep 4, 2022
@novemberborn novemberborn merged commit ea597d8 into avajs:main Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novemberborn novemberborn novemberborn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override process.exit to give some context when it's called unexpectedly in a test.
2 participants
@gibson042 @novemberborn