Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap idle timeouts to the maximum possible value #3100

Merged
merged 3 commits into from Sep 5, 2022

Conversation

creestor
Copy link
Contributor

@creestor creestor commented Sep 4, 2022

I have fixed this issue : #3060.
Was added constraint for max time of setTimeout.

Copy link
Member

@novemberborn novemberborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @creestor! I've left some comments, also you'll have to run npx xo --fix to fix the linting issues.

lib/now-and-timers.cjs Outdated Show resolved Hide resolved
lib/now-and-timers.cjs Outdated Show resolved Hide resolved
@novemberborn novemberborn changed the title Fixed timer, added max avaliable timeout value Cap idle timeouts to the maximum possible value Sep 5, 2022
@novemberborn novemberborn merged commit 52b2270 into avajs:main Sep 5, 2022
12 checks passed
@novemberborn
Copy link
Member

Thanks @creestor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants