Update to the browser testing recipe to use jsdom directly #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidVujic
force-pushed
the
docs_browser_unit_tests
branch
from
d46d6f4
to
5ff982e
Compare
DavidVujic
force-pushed
the
docs_browser_unit_tests
branch
from
5ff982e
to
d376a78
Compare
novemberborn
changed the title
|
Nice one, thanks @DavidVujic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I am suggesting to use
jsdomdirectly instead of thebrowser-envtool. Even though it is a helpful tool, browser-env hasn't been updated in many years as it seems.I also believe the suggestions here about writing unit tests for JavaScript in the browser are more explicit, by adding only the necessary globals and DOM elements for the particular test target. I like to see it as a TDD friendly approach 😄