-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bluebird warnings #334
Conversation
What warnings are you seeing? I can not reproduce. |
Hmm, I still don't see that error. Either way though, it is probably a good idea to stop using a deprecated API. My only objection is the additional nesting. |
@jamestalmage: Well, you have two options:
Personally, #1 seems way more reasonable to me, but in the end it's up to you. |
Well it i no where near 15 lines. But still, I tend to agree with you, not worth doing. var deferred = {};
deferred.promise = new Promise(function (resolve, reject) {
deferred.resolve = resolve;
deferred.reject = reject;
}); LGTM |
Yeah. Let's just nest. I think the code is clearer this way too. |
I'm still getting one these traces for every test in 0.10
|
@Lokua Use our gitter chat for support. Are you sure you're on the latest AVA version locally (and globally if you run AVA from the command line with |
Hi All,
This is a simple PR, it just fixes a warning from bluebird (about deferreds).
Enjoy!