Follow-up to #831. #835
Merged
Follow-up to #831. #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,7 +191,7 @@ Test.prototype._result = function () { | |||
| if (this.metadata.failing) { | |||
| passed = !passed; | |||
| if (!passed) { | |||
| reason = new Error('Test was expected to fail, but succeeded, you should unmark the test as failing'); | |||
| reason = new Error('Test was expected to fail, but succeeded. You should stop marking the test as failing'); | |||
There was a problem hiding this comment.
It's kinda weird only having a . after the first sentence.
There was a problem hiding this comment.
We might want an ESLint rule for this, either way.
There was a problem hiding this comment.
OK, reverted to the original succeeded, you should form.
ESLint rule?
There was a problem hiding this comment.
The tests are better when grouped together. I tried to give them more consistent titles too.
novemberborn
force-pushed
the
831-follow-up
branch
from
d479ddc
to
b1b03f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #831.