-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract ava-files to it's own module #925
Conversation
Is the watcher still broken with this? (Didn't check why CI failed.) Do we want to remove the |
this.options = options || {}; | ||
this.options = objectAssign({}, options); | ||
this.options.cwd = this.options.cwd || process.cwd(); | ||
this.options.resolveTestsFrom = this.options.resolveTestsFrom || this.options.cwd; | ||
this.options.match = this.options.match || []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above 3 options can just be put as defaults in the objectAssign call.
The CI failure was unrelated (npm install checksum errors), I restarted and it passed. Neither this or #863 "broke" watcher. But it doesn't improve it either. With this you can do It is a little more complicated to make watcher work in a subdir. As agreed, the |
64f2b8f
to
3a7a1ca
Compare
This will allow other tools (i.e. atom-ava, linter, etc) to have access to the file selection logic.
The external module includes the updates from #863, so I have closed that.