-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
|
||
test('${3:title}', t => { | ||
test(${3/(.+)|.*/?1:'/}${3:title}${3/(.+)|.*/?1:', /}t => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the |.*
part really needed? If yes, what purpose does it have? I might be missing something obvious since it's late here, but seems to be working fine without.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hell no! Tiredness make me write unecessary complicated patterns. As you will see in the next commit, the final regex is wayyyy simpler. Thank you.
I think you made the right choice. Just open an issue when this PR is merged about finding a solution and maybe someone will come along and know a better way ;) |
This is really cool. I like it a lot :) |
I’ve also corrected a typo in the test-serial snippet. |
Let's first notify them: sublimehq/sublime_text#1132 ;-) |
That's not an official issue tracker. You'd probably have better luck in the official forum: https://forum.sublimetext.com/ |
Awesome! Thanks for working on this @kipit :) |
I opened an issue here too so we can track it better: #6 |
@kipit Would you be interested in working on #1? Should be easy to port the Atom ones: https://github.com/sindresorhus/atom-ava/blob/master/snippets/assertions.json |
Small improvements introducing :
This PR also contain a file renaming (cmd+D are you there?).