Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] mrp_production_fix_out_move: No duplicate stock picking move li… #20

Merged
merged 1 commit into from
Dec 11, 2018
Merged

[ADD] mrp_production_fix_out_move: No duplicate stock picking move li… #20

merged 1 commit into from
Dec 11, 2018

Conversation

alfredoavanzosc
Copy link
Contributor

…nes from production.

@codecov
Copy link

codecov bot commented Dec 5, 2018 •
edited
Loading

Codecov Report

Merging #20 into 8.0 will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              8.0      #20      +/-   ##
==========================================
+ Coverage   94.86%   94.97%   +0.11%     
==========================================
  Files          48       49       +1     
  Lines        1187     1213      +26     
==========================================
+ Hits         1126     1152      +26     
  Misses         61       61
Impacted Files Coverage Δ
...p_production_fix_out_move/models/mrp_production.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3ba71a...983460e. Read the comment docs.

@alfredoavanzosc
Copy link
Contributor Author

@avanzosc/developers ... review please.

mikelarre
mikelarre previously approved these changes Dec 5, 2018
View reviewed changes
oihane
oihane reviewed Dec 5, 2018
View reviewed changes
mrp_production_fix_out_move/README.rst Outdated
===========================

* When a product is produced, in the out picking, generated from sale order,
the movement not duplicated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No se entiende que hace el modulo

oihane
oihane reviewed Dec 5, 2018
View reviewed changes
mrp_production_fix_out_move/README.rst Outdated
===========

Bugs are tracked on `GitHub Issues
<https://github.com/avanzosc/custom-addons/issues>`_. In case of trouble,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La dirección es incorrecta

oihane
oihane reviewed Dec 5, 2018
View reviewed changes
mrp_production_fix_out_move/tests/test_mrp_production_fix_out_move.py Outdated
@@ -0,0 +1,97 @@
# -*- coding: utf-8 -*-
# (c) 2018 Alfredo de la Fuente - AvanzOSC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se pone Copyright

@alfredoavanzosc
Copy link
Contributor Author

Se han hecho las mejoras solicitadas por @oihane , y se ha vuelto a subir el módulo.

Daniel-CA
Daniel-CA reviewed Dec 10, 2018
View reviewed changes
Copy link
Collaborator

@Daniel-CA Daniel-CA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tampoco se si el nombre sería el correcto. Al final según entiendo la modificación se realiza por que el cliente necesita que funcione de esa manera la producción, si @anajuaristi lo ve bien por mi no hay problema.

mrp_production_fix_out_move/README.rst
and one manufacturig order are generated. If the manufacturing order is
produced partially, the movement of the picking is divided. This module means
that this movement is not divided in the picking.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo cambiaría la última frade por:
This module prevents that movement is divided

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realizada la mejora solicitada por @Daniel-CA , y subido el módulo. Eskerik asko.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 94.971% when pulling 983460e on alfredoavanzosc:mrp-mrp_production_fix_out_move into d3ba71a on avanzosc:8.0.

@anajuaristi anajuaristi merged commit afa2402 into avanzosc:8.0 Dec 11, 2018
@alfredoavanzosc alfredoavanzosc deleted the mrp-mrp_production_fix_out_move branch December 11, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oihane oihane oihane left review comments

@anajuaristi anajuaristi anajuaristi approved these changes

@Daniel-CA Daniel-CA Daniel-CA approved these changes

@mikelarre mikelarre mikelarre approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alfredoavanzosc @coveralls @anajuaristi @oihane @Daniel-CA @mikelarre