Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] version_modules: create version product when MO is confirmed #93

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

mikelarre
Copy link
Contributor

No description provided.

product_version = version_obj._find_create_version(
self.product_id.id, self.custom_value_ids)
if product_version:
self.product_version_id = product_version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por qué no asignar directamente?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok zuzenduta

@mikelarre mikelarre force-pushed the version_create_mo_confirm branch 3 times, most recently from c71b09b to 10fa085 Compare June 1, 2021 13:35
Copy link
Contributor

@alfredoavanzosc alfredoavanzosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@mikelarre mikelarre force-pushed the version_create_mo_confirm branch 2 times, most recently from 81c134b to 4f98f9f Compare June 11, 2021 11:44
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #93 (f3226c7) into 12.0 (5b8d286) will increase coverage by 1.68%.
The diff coverage is 66.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0      #93      +/-   ##
==========================================
+ Coverage   61.99%   63.68%   +1.68%     
==========================================
  Files          25       28       +3     
  Lines         842      950     +108     
==========================================
+ Hits          522      605      +83     
- Misses        320      345      +25     
Impacted Files Coverage Δ
...uction_generate_structure/models/mrp_production.py 32.57% <0.00%> (ø)
...ariant_custom_stock/models/stock_production_lot.py 57.14% <ø> (-1.95%) ⬇️
product_variant_custom/models/product_product.py 23.76% <17.24%> (-3.64%) ⬇️
mrp_scheduled_products/models/mrp.py 92.30% <20.00%> (-4.21%) ⬇️
product_variant_custom/models/product_version.py 34.09% <35.29%> (+0.28%) ⬆️
product_variant_custom/models/product_template.py 50.00% <50.00%> (ø)
mrp_usability/models/mrp_production.py 84.61% <60.00%> (-15.39%) ⬇️
sale_line_mrp_link/models/mrp_production.py 82.35% <70.00%> (-17.65%) ⬇️
sale_line_mrp_link/models/stock_rule.py 92.00% <90.47%> (+52.00%) ⬆️
...t_variant_custom/models/product_attribute_value.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 458bd4a...f3226c7. Read the comment docs.

@mikelarre mikelarre merged commit aef3075 into avanzosc:12.0 Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants