-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$SHARE_DIR cleanup on install??? #12
Comments
Well, I must say that after a long time playing with it only in our set environments, we were kinda expecting something like this when released. But rm-rf-ing parts of We will not be able to fix it today, but I at least added a warning in c1206a6, and solving this will be the first task tomorrow. |
I ran into this yesterday. Luckily, I tried to install as a regular user and did not run with |
…ctory (#12). Remove only the subdirectories and files that are used by RetDec. This should reduce the chance of unintentionally removing system directories when RetDec is accidentally installed on Linux into e.g. `/usr` as the `arm`, `generic`, and `x86` directories are not commonly used by Linux distributions. Nevertheless, as mentioned in our README, until our build system properly supports system-wide installations, RetDec should to be installed into a clean, dedicated directory.
Thank you very much for your report! In 03ea29a, I have modified the script to not remove the entire Nevertheless, until our build system properly supports system-wide installation, RetDec should be installed into a clean, dedicated directory. |
this should solve #12. script no longer clears (rm -rf) <install_dir>/share, it clears <install_dir>/share/retdec/support.
After fb9b340 and #31, installation creates:
Only After this, we are one step closer to a system-wide installation. However, I still would not recommend it -- there are to many binaries, scripts, and stuff in |
…ctory (avast#12). Remove only the subdirectories and files that are used by RetDec. This should reduce the chance of unintentionally removing system directories when RetDec is accidentally installed on Linux into e.g. `/usr` as the `arm`, `generic`, and `x86` directories are not commonly used by Linux distributions. Nevertheless, as mentioned in our README, until our build system properly supports system-wide installations, RetDec should to be installed into a clean, dedicated directory.
this should solve avast#12. script no longer clears (rm -rf) <install_dir>/share, it clears <install_dir>/share/retdec/support.
While not exactly recommended by README, If I ever wanted to install into /usr or /usr/local prefix your
retdec/cmake/install-share.sh
wouldrm -rf
my $SHARE_DIR.Please fix before somebody tries to install into their /usr.
The text was updated successfully, but these errors were encountered: