Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate "lib*.a(filexx.cpp.o)" has no symbols on macOS #349

Merged
merged 5 commits into from
Jul 10, 2018

Conversation

Maroc-OS
Copy link
Contributor

@Maroc-OS Maroc-OS commented Jul 3, 2018

On macOS there is some warnings about object that has no symbols in it, this is needed to be fixed to make building more clean and clear.

example of build log :

[ 94%] Linking CXX static library libretdec-bin2llvmir.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libretdec-bin2llvmir.a(idioms_borland.cpp.o) has no symbols

Fix compiler warning (unused variable 'ai')
On macOS there is some warnings about object that has no symbols in it, this is needed to be fixed to make building more clean and clear.

example of build log :
```
[ 94%] Linking CXX static library libretdec-bin2llvmir.a
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: libretdec-bin2llvmir.a(idioms_borland.cpp.o) has no symbols
```
Unify build visibility for all projects to avoid warnings "direct access in function: * from file: * to global weak symbol".

PS: used same function 'append_if' from LLVM Project CMakeLists.txt file

This will fix avast#331
FIX: avast#331 Unify build visibility for all projects
@Maroc-OS
Copy link
Contributor Author

Maroc-OS commented Jul 3, 2018

After those, there will be no warnings at all on macOS compile time.

@Maroc-OS
Copy link
Contributor Author

Maroc-OS commented Jul 3, 2018

@s3rvac could you take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants