Added support for checking presumably missing dependencies #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladislav-zezula
force-pushed
the
LZ_CheckMissingDependencies
branch
from
ffd6d90
to
8d926e5
Compare
metthal
requested changes
Jun 13, 2019
| @@ -57,7 +60,7 @@ class ImportTable | |||
| /// @{ | |||
| void computeHashes(); | |||
| void clear(); | |||
| void addLibrary(std::string name); | |||
| void addLibrary(std::string name, bool bIsMissingDependency = false); | |||
There was a problem hiding this comment.
We are not using hungarian notation anywhere in our projects so it seems rather inconsistent. Could you please rename it to isMissingDependency?
| #include "retdec/utils/dynamic_buffer.h" | ||
| #include "retdec/fileformat/file_format/pe/pe_format.h" | ||
|
|
||
| /** |
There was a problem hiding this comment.
This should be the very first thing in the file. Followed by includes.
| } | ||
|
|
||
| desc.push_back("Number of missing dependencies: "); | ||
| sprintf(szNumDeps, "%u", (unsigned)fileinfo.getNumberOfMissingDeps()); |
There was a problem hiding this comment.
We have conversion functions available in utils/conversion.h. numToStr can be used here.
| return false; | ||
| } | ||
|
|
||
| sprintf(szIndex, "%u", (unsigned)recIndex); |
| return false; | ||
| } | ||
|
|
||
| sprintf(szIndex, "%u", (unsigned)recIndex); |
| const auto numberOfMissingDeps = fileinfo.getNumberOfMissingDeps(); | ||
|
|
||
| Value jMissingDeps; | ||
| jMissingDeps["count"] = (unsigned int)numberOfMissingDeps; |
There was a problem hiding this comment.
One thing with fileinfo is that we present everything in JSON as strings and I think everyone working with fileinfo JSONs kinda expects this. Would it be possible to present this value as string too?
|
Fixed in commit 44063e76f38f4c1a952fb0541f48a2a608aa0566 |
metthal
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.