utils: fix #842, always link stdc++fs if linux & gcc. #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this with |
xkubov
pushed a commit
that referenced
this pull request
Sep 1, 2020
Deletes aditional note for filsystem library. After #846 RetDec should handle manually all cases for filsystem library in the system. Build should be possible without special effort on any major system that is supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #842 by always linking against stdc++fs on Linux&GCC combo.
Notes:
CMAKE_CXX_COMPILER_VERSIONto check for GCC 7/8, but I didn't want to complicate it.@xkubov Please take a look and merge if ok.