Added CWTOutput class to fix the issues with the new main cwt method.… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Then I fixed all the tests
Closed
zdanaceau
requested changes
Jul 27, 2022
FCWTAPI/CWTObject.cs
Outdated
| default: | ||
| return null; | ||
| } | ||
| } | ||
| private double[,] GetComponent(CWTComponent comp, double[,] originalArray) |
There was a problem hiding this comment.
Is the intention for this method to be removed/rendered obsolete?
FCWTAPI/CWTObject.cs
Outdated
| @@ -86,6 +86,20 @@ public void SplitRealAndImaginary(CWTComponent comp, out double[,]? realCwt, out | |||
| break; | |||
| } | |||
| } | |||
| public double[,]? GetComponent(CWTComponent comp, CWTOutput cwtOutput) | |||
There was a problem hiding this comment.
If the only function of this method to return Real, Imaginary or Both as as a single array, wouldn't it make more sense to just have a method to get both components in a single array since SplitRealAndImaginary already gets a double[ , ] corresponding to the real and imaginary components?
FCWTAPI/CWTOutput.cs
Outdated
| { | ||
| case 0: return cwtoutput.RealArray.GetLength(0); | ||
| case 1: return cwtoutput.RealArray.GetLength(1); | ||
| default: return -1; |
There was a problem hiding this comment.
Would it be better to throw an exception here to make it more traceable if an int != 0 or 1 was entered?
| double testPoint = Math.Atan(imagCwt[32, 32] / realCwt[32, 32]); | ||
| Assert.AreEqual(testPoint, testPhase[32, 32], 0.001); | ||
| } | ||
| //[Test] |
There was a problem hiding this comment.
Why did you comment this out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Then I fixed all the tests