Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module_exec instead of module_eval whenever having variables #24

Merged
merged 1 commit into from
Jun 1, 2013

Conversation

samnang
Copy link
Contributor

@samnang samnang commented Jun 1, 2013

Instead of having to assign a temp local variable to be able to access closure block, should we use module_exec instead?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0d6abfe on samnang:use_module_exec into e740fc4 on avdi:master.

@avdi
Copy link
Owner

avdi commented Jun 1, 2013

I'm convinced :-) Feel free to update other instances of module_exec. Honestly at this point I'm wondering if there's any reason to use module_eval at all in a project that assumes Ruby 1.9+ (and doesn't eval strings).

avdi pushed a commit that referenced this pull request Jun 1, 2013
Use `module_exec` instead of `module_eval` whenever having variables
@avdi avdi merged commit 051d084 into avdi:master Jun 1, 2013
@avdi
Copy link
Owner

avdi commented Jun 1, 2013

Er, feel free to update other instances of module_eval, I mean.

@samnang
Copy link
Contributor Author

samnang commented Jun 1, 2013

@avdi it has been merged, do I have to push to another branch and pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants