Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual lookup.py categories with block tags? #61

Open
avdstaaij opened this issue Feb 28, 2023 · 1 comment
Open

Replace manual lookup.py categories with block tags? #61

avdstaaij opened this issue Feb 28, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@avdstaaij
Copy link
Owner

Minecraft uses block tags to define all kinds of block categories. These categories might be able to replace the current manual categories in lookup.py.

Advantages:

  • The categories would become less arbitrary and more standardized.
  • The categories could be (semi-)automatically updated for new Minecraft versions. (!)
  • Various new categories, like "mineable/pickaxe", would be added.

Disadvantages:

  • Lots of categories would be lost.
  • There would only be categories for full block names, so no categories like WOOD_TYPES.
  • This would be a substantial breaking change.

Of course, we could also include both, but the main advantage of block tag-based categories is reduced maintenance...

A JSON dataset with all blocks and their default block tags (block tags for their default BlockState) has already been created by @ShinySilver. It is available in the GDMC Discord, though currently only to members with the framework-developer role.

Should the manual categories be replaced with block tag-based categories?

@avdstaaij avdstaaij added question Further information is requested cleanup Tidying up code to improve usability labels Feb 28, 2023
@avdstaaij
Copy link
Owner Author

For multiple-version-support (#99), the manual categories will definitely have to go. The block tag plan outlined here would theoretically be possible, but we would have to maintain a list of all block tags for each supported version of Minecraft. I don't think it's a good idea to that in GDPC itself, but it could be viable to maintain a separate repository with this information (a-la https://github.com/SpockBotMC/python-minecraft-data, see also #89). I'll leave this open for now.

@avdstaaij avdstaaij added enhancement New feature or request and removed question Further information is requested cleanup Tidying up code to improve usability labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant