-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added list of artificial blocks and some fixes for lookup.py #83
Conversation
Hmm, while this is certainly useful, I'm not sure if adding even more manual categories to lookup.py is a good idea. It may seem like it would be just a plus, but if people start actually using and depending on these categories, we also need to constantly update them for future versions. Like the file docstring in lookup.py says, I am actually considering removing the manual categories altogether. See also #61. The fixes to the existing categories are of course welcome! Please submit them as a separate PR. I'll leave this PR open for now in case I reconsider. |
It would also be acceptable to remove any natural blocks from |
This was also my first instinct, we can obviously remove |
I hadn't thought of the semi-natural blocks like |
It's been a while, but I've decided to close this. The manual block categories in |
Ive added a list of artificial blocks, these are blocks that are not occurring naturally. These blocks are only used in minecraft generated structures or human-created structures. Also includes some spelling fixes.
Useful for detecting pre-existing structures when choosing building locations for gdmc. Note that the already present
VILLAGE_BLOCKS
are all blocks that spawn in these villages and thus also include natural blocks which makes them useless for gdmc purposes.There may be some artificial blocks that are missed in this list, please add to it if you know anything.