Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ftpserverlib #3165

Closed
wants to merge 1 commit into from
Closed

Adding ftpserverlib #3165

wants to merge 1 commit into from

Conversation

fclairamb
Copy link
Contributor

@fclairamb fclairamb commented Jul 12, 2020

  • ftpserverlib is a library to help you build your own FTP server easily

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Links:

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order.
  • I have an appropriate description with correct grammar.
  • I know that this package was not listed before.
  • I have added pkg.go.dev link to the repo and to my pull request.
  • I have added coverage service link to the repo and to my pull request.
  • I have added goreportcard link to the repo and to my pull request.
  • I have read Contribution guidelines, maintainers note and Quality standard.

Thanks for your PR, you're awesome! 👍

- ftpserverlib is a library to help you build your own FTP server easily
- ftpserver is a ready-to-use FTP server based on this library and with a S3 and SFTP backend implementation
@avelino
Copy link
Owner

avelino commented Jul 12, 2020

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: True
  • coverage: True

Copy link
Collaborator

@panjf2000 panjf2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open one PR per lib, in case one lib is qualified and another one is not, then the latter stall the former to be merged, also fix some code issues like https://goreportcard.com/report/github.com/fclairamb/ftpserver#golint, and increase the code coverage to >=80%.

@github-actions
Copy link

This PR has been automatically marked as closed because it has not had recent activity. They will wait 15 days for your interaction, after that the PR will be closed. Please read more in https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

@github-actions github-actions bot added the stale label Sep 17, 2020
@github-actions github-actions bot closed this Sep 24, 2020
@fclairamb fclairamb changed the title Adding ftpserver + ftpserverlib Adding ftpserverlib Dec 31, 2020
@fclairamb fclairamb mentioned this pull request Dec 31, 2020
7 tasks
@fclairamb fclairamb mentioned this pull request Feb 6, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants