Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Allow optional labels #2

Merged
merged 5 commits into from
Jun 14, 2022
Merged

Allow optional labels #2

merged 5 commits into from
Jun 14, 2022

Conversation

alex-schneider
Copy link

No description provided.

johakoch
johakoch approved these changes Jun 14, 2022
View reviewed changes
Copy link

@johakoch johakoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LabelOptional == true is probably insufficient, if, like in the new test case, one label is mandatory and one is optional.

If, however, there is only one label defined, which is optional, this approach looks ok.

@johakoch johakoch merged commit d3e1084 into main Jun 14, 2022
@alex-schneider alex-schneider deleted the optional-label branch June 14, 2022 11:32
@johakoch johakoch mentioned this pull request Jan 31, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johakoch johakoch johakoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-schneider @johakoch