Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make djunits dependent on djutils-base to avoid code duplication #8

Closed
averbraeck opened this issue Apr 30, 2023 · 1 comment
Closed

Make djunits dependent on djutils-base to avoid code duplication #8

averbraeck opened this issue Apr 30, 2023 · 1 comment
Assignees
@averbraeck
Labels
simplification Simplification o code

Comments

@averbraeck
Copy link
Owner

djunits has quite some code duplication (Try, Throw, ClassUtil, etc.) with djutils to avoid a dependency on djutils. Now that NumberParser will also be used by djunits, a dependency and avoiding code duplication seems like a better solution.
@averbraeck averbraeck added the simplification Simplification o code label Apr 30, 2023
@averbraeck averbraeck self-assigned this Apr 30, 2023
averbraeck added a commit that referenced this issue Apr 30, 2023
@averbraeck
Issue #8. Dependency on djutils-base to avoid code duplication
75b96bd
averbraeck added a commit that referenced this issue Apr 30, 2023
@averbraeck
Issue #8. Removal of duplicate classes with djutils
843308c
averbraeck added a commit that referenced this issue Apr 30, 2023
@averbraeck
Issue #8. Update test code for dependency on djutils.
0592881
averbraeck added a commit that referenced this issue Apr 30, 2023
@averbraeck
Issue #8. Import statements adapted to dependency on djutils
107390f
averbraeck added a commit that referenced this issue Apr 30, 2023
@averbraeck
Issue #8. Update unit tests to Try.testFail(() -> code)
22d2e0c
@averbraeck
Copy link
Owner Author

All updates made to compensate for the classes that are now taken out of the djunits code, and point to the right classes in djutils (including signature changes of methods, such as the Try.testFail(...) method calls).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averbraeck averbraeck

Labels
simplification Simplification o code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@averbraeck