-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining differences with elm/core
#650
Comments
Regarding andThen lambdas alignment #568 |
This looks like an issue, which I assume only affects code blocks in doc comments.
Is this actually a bug? Does elm-markdown not support shortcut reference links https://spec.commonmark.org/0.29/#shortcut-reference-link (babelmark) ? |
What I think is a bug is that I have submitted a fix proposal in #649. However I don't know that well "shortcut reference link`, so I may have overlooked something. |
Oh I see 👍 I was looking at
instead of |
I'm sorry you were right. The markdown bug exists but does not occur in |
Yes, it seems linked to the unary minus being interpreted as a minus operator in a multi-line expression. I have opened #652. |
I think the Unicode characters case was fixed in 0.8.4. |
In the spirit of targeting 1.0 being used in core libraries, I did a diff with
elm/core
using Allow single-lineif
expressions and Allow single-line case-expressions branches to see if there are major differences that could require some remaining discussion.As
elm/core
seems to mix indentations of 2 spaces vs 4 spaces, uses[1, 2, 3]
syntax for lists/tuples instead of[ 1, 2, 3 ]
, and does not always put the same blank lines, here is thegit diff
result usinggit diff --ignore-all-space --ignore-blank-lines | grep -v '^\+$'
:So it looks pretty good. Here are a few remaining differences worth mentioning:
1. Unicode characters
in documentation is replaced by:
This breaks the point of the example.
2. Arithmetic expressions examples
The following arithmetic examples:
become broken:
3.
Markdown link bugThis is due to #339.Edit: I was thinking about another bug about markdown links.
This one is not a bug and should therefore not be an issue for
elm/core
withelm-format
.4.
andThen
lambdas alignmentBecomes
I know that this has been already discussed, but is there anelm-format
issue for this?Edit: Discussed in #568
Should this be part of
0.9.0-exp last experimental features before 1.0
milestone?The text was updated successfully, but these errors were encountered: