WIP: Parsec API for the new Elm parser #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that `parserPlus` does not handle error merging properly, there is an `undefined` there. I'll need to figure out to what extent proper error handling is needed, does elm-format give specific error messages on syntax errors?
Turns out that `IndentParser` and even the `State SourcePos` bit used by `indents` can be factored out! So much simple now.
|
Turns out not all tasts are passing after all. |
avh4
reviewed
Jul 13, 2021
| -- | ||
| -- Let's not devle into this unless it turns out that elm-format | ||
| -- needs it. | ||
| 0x0d {- "\r" -} -> error "Can't handle carrige return" |
There was a problem hiding this comment.
If I remember correctly, elm-format will never output CRs, but it does read them. For ones in literal strings, it will convert them to an escape sequence. And for ones elsewhere, it will treat them either as newlines or whitespace (I forget which).
avh4
changed the title
kutyel
pushed a commit
to kutyel/elm-format
that referenced
this pull request
Apr 26, 2022
WIP: Parsec API for the new Elm parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is the first step in an effort to integrate the parser from the Elm compiler into elm-format as part of a GSOC project (project proposal).
This PR removes the dependency on parsec and indents which have been used by elm-format to parse Elm code. The API these libraries provided has been replaced with drop-in replacement modules (located in
Text.Parsec.*) compatible with elm-format. These replacement modules are implemented in terms of the new Elm parser (located inParse.Primitivesand copied from the Elm compiler).new-parser-2021-notes.mdin the project root goes into more detail on some specifics relating to this project.The entire test suite passes.