Stripe gateway minor fixes and docs update #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chandradot99
commented
Jan 3, 2018
chandradot99
commented
- add guard clause when source params is token or customer
- trim name since it will contain the extra space when first_name or last_name is not passed in card struct.
- don't change the struct into map, access card params from struct only
- change stripe docs according to new credit card and address struct
- change expiration year in README.md
…last_name is not passed in card struct. * don't change the struct into map, access card params from struct only
oyeb
requested changes
Jan 3, 2018
lib/gringotts/gateways/stripe.ex
Outdated
| iex> amount = 10 | ||
|
|
||
| iex> Gringotts.authorize(Gringotts.Gateways.Stripe, amount, payment, opts) | ||
| iex> Gringotts.authorize(Gringotts.Gateways.Stripe, amount, card, opts) | ||
| """ | ||
| @spec authorize(Float, Map, List) :: Map |
There was a problem hiding this comment.
Many of your @specs are wrong, this one should be:
@spec authorize(float, CreditCard.t | String.t, keyword) :: mapPls refer the typespecs docs.
|
@oyeb I have made the requested changes, can you verify once again as it need to merged soon. |
oyeb
approved these changes
Jan 4, 2018
pkrawat1
pushed a commit
that referenced
this pull request
Jan 25, 2018
* separate payment into credit card and address struct * set default currency if currency not passed in options * add guard clause when source params is token or customer * Change stripe docs according to new credit card and address struct * Updated Readme * Fixed specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.