Array merge by id schema generation

[birdsarah]

Hi,

Schema generation on arrayMergeById wasn't quite right. The full problem I was trying to solve you can see here: open-contracting/standard@2104706 I think the tests captured it. Things seem to be working as I expect now although I have to confess I'm not entirely sure I understand why!

[avian2]

Ah, yes. There should indeed be a call to walk.descend() in get_schema() somewhere, because the merge() is also descending into subschemas. But this looks weird, since you're discarding schema2 here. I'll have to think about it.

[avian2]

The fact that it works this way is a bit of luck. walk.descend() was not meant to be used this way. But I can't find any example where it would break, so I'm merging this.

What you are trying to do here is have get_schema() not replace a $ref reference with a copy of the object it points to. I think you are correct in assuming there is no need for that. But the code in WalkSchema was designed to always do that on the first level (like objectMerge does). This is kind of a workaround that happens to work, but I'll see if WalkSchema.descend() can be improved to be smarter about references.