Create subdirectories if specified in password path #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will take a look soon! Thanks for the pr :) |
mdellweg
force-pushed
the
create_subdirs_if_needed
branch
from
b61db5b
to
ce1e361
Compare
This patch allows to specify password entries in subdirectories. If the directory does not exist, it will be created before invoking gnupg.
mdellweg
force-pushed
the
create_subdirs_if_needed
branch
from
ce1e361
to
af7a506
Compare
|
Can you assert that the directory does not exist before? Sorry for the slow reviews! I'll try to review faster. |
|
Do you mean before creating the path, or in the tests? |
|
in the tests. |
|
Now that travis seems to be functional again, can you restart the test? |
aviau
approved these changes
Jan 17, 2018
|
Thank you! Very nice project btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows to specify password entries in subdirectories.
If the directory does not exist, it will be created before invoking gnupg.