Fix xclip on Travis. #22
Conversation
|
nicee! Would it work if we put export DISPLAY=:99.0 in before_script? So that we wouldn't have to copy it to every env. |
|
Seems like it would. :-) |
.travis.yml
Outdated
| @@ -29,8 +29,12 @@ install: | |||
| - git config --global user.email "you@example.com" | |||
| - git config --global user.name "Your Name" | |||
| - sudo apt-get install -y tree | |||
| - sudo apt-get install -y xclip | |||
There was a problem hiding this comment.
can you merge this with the other apt-get install so that it is faster?
apt-get install -y tree xclip
| def test_generate_clip(self): | ||
| generate = self.run_cli(['generate', '-c', 'clip.me']) | ||
|
|
||
| self.assertEqual(generate.output, 'Copied clip.me to clipboard.\n') | ||
|
|
||
| time.sleep(0.1) |
There was a problem hiding this comment.
Aww this is required?
timing dependent tests always bite you back.
Is this because pypass exits before waiting for xclip to exit?
There was a problem hiding this comment.
Unfortunately, I'm not well versed in the inner workings of xclip, but if my intuition is correct, invoking xclip is async: it terminates the invoked process before its background process clears and writes on (also propably not atomically) the clipboard. Therefore, this test could (and sometimes did before I added time.sleep) read the clipboard before the desired content is there. Since there isn't a Future I could wait on, I chose this method instead.
What I really don't understand is why this test is problematic, but test_show_clip() seems to work like a charm, and they are coded the same way...
I appreciate every pointer in the right direction.
I started
Xvfband set up theDISPLAYenvironment variable on Travis, soxcliptests can be run.Also sorry for chiming in on an earlier pull request by referencing it, it was unintentional.