Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refactor): restart the app using the process phoenix #211

Merged
merged 2 commits into from
Jan 28, 2023
Merged

fix(refactor): restart the app using the process phoenix #211

merged 2 commits into from
Jan 28, 2023

Conversation

HammzaHM
Copy link
Contributor

No description provided.

@todorone
Copy link

@avishayil This seems as much more reliable way to restart the app avoiding reported crashes and setTimeout workarounds. Could You please consider to merge it?

@avishayil
Copy link
Owner

Testing since Travis decided to stop working on PRs

@Nikola-Andreev
Copy link

@avishayil how did the testing go?

@todorone
Copy link

@avishayil If You worry about regression, at least "alpha"-ish release is highly appreciated. Thanks.

@dan-trewin
Copy link

any update on a release for this?

@HammzaHM
Copy link
Contributor Author

@todorone I've made custom native module using this approach of restarting the app, and our app is live without any regressions

@dutradotdev
Copy link

+1
i need this fix!

@dutradotdev
Copy link

@avishayil pls merge

@cicatrizdev
Copy link

+1

@dan-trewin
Copy link

@avishayil Whats the status on this? Plz merge. looks like it got approved.

@manny-cuboh
Copy link

@avishayil would also love this merged!

@avishayil
Copy link
Owner

Thanks @HammzaHM for this! looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants