Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subject Type name not shown in UserGroup Privilege assignment screen #1004

Closed
himeshr opened this issue Jul 20, 2023 · 3 comments
Closed

Subject Type name not shown in UserGroup Privilege assignment screen #1004

himeshr opened this issue Jul 20, 2023 · 3 comments
Assignees
@himeshr

Comments

@himeshr
Copy link
Contributor

himeshr commented Jul 20, 2023 •
edited by vinayvenu
Loading

Describe the bug
Subject Type name not shown in UserGroup Privilege assignment screen

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Admin' app in Avni-webapp
  2. Click on 'UserGroups' in left-side tab
  3. Click on any user group
  4. Click on "Privileges" tab
  5. See that SubjectTypes info is missing

Expected behavior
Subject Type info should be shown in UserGroup Privilege assignment screen

Screenshots
Image
@vinayvenu vinayvenu changed the title Subject Type info not shown in UserGroup Privilege assignment screen Subject Type name not shown in UserGroup Privilege assignment screen Jul 20, 2023
@himeshr himeshr self-assigned this Jul 21, 2023
himeshr added a commit that referenced this issue Jul 21, 2023
@himeshr
#1004 | Introduce new column "Subject / Entity Type" for grouping pur…
c77d372 
…pose in Edit Group Privileges screen
@himeshr
Copy link
Contributor Author

himeshr commented Jul 21, 2023

Screenshot after the change:

Image

@petmongrels
Copy link
Contributor

the data managed by saga is meant to be used in multiple places. hence instead of modifying the store data we should pull the data and modify it according to the needs of the view where it is actually used.

himeshr added a commit that referenced this issue Jul 27, 2023
@himeshr
#1004 | Do not modify the store data, instead modify it as required i…
b48e4f0 
…n GroupPrivileges view
@himeshr
Copy link
Contributor Author

himeshr commented Jul 27, 2023

@petmongrels, made the code changes as suggested..

himeshr added a commit that referenced this issue Jul 28, 2023
@himeshr
#1004 | Hide users list if User doesnot have EditUserConfig privilege
3508201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himeshr himeshr

Labels
None yet
Projects
Avni Product
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petmongrels @vinayvenu @himeshr