Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App designer should not break on invalid glific configuration #1208

Open
Tracked by #1573 ...
mahalakshme opened this issue Apr 30, 2024 · 3 comments
Open
Tracked by #1573 ...

App designer should not break on invalid glific configuration #1208

mahalakshme opened this issue Apr 30, 2024 · 3 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Apr 30, 2024

https://avni.freshdesk.com/a/tickets/3352

Steps to reproduce:

  • Any org without valid glific configuration
  • In Organisation details toggle on Enable Messaging
  • Open a subject type in App designer
  • We show the oops error page

Need:

Issue raised by several tickets and people in implementation team.

Acceptance criteria:

when the /messageTemplates call fails, do the below on different scenarios,

  • In the Show mode, when the /messageTemplates call fails, and when there are no message rules, it should not fail, and the subject type need to show
  • In the Edit mode, when the /messageTemplates call fails, and when there are no message rules, show the error message as below along with other usual subject type information on click of 'Add new message rule'
    Image
  • In the Show mode, when there are message rules, show the other subject type info, along with the error message as above.
  • In the Edit mode, when there are message rules, show the other subject type info, alone with the error message as above. When user tries to add more message rules by clicking on 'Add new message rule', again show the above error message. It is okay if the error message displays multiple times on the page
  • The above needs to work across entity types (program, subject type, encounter type)
  • Similar above behaviour for User Messaging Config of App designer as well.

Analysis reason:

The above was decided to be done, instead of handling it when toggling on Enable Messaging in Organisation Details because of the below reasons:

  • The credentials might become invalid at a later point of time, after enabling messaging.
  • The implementation engineer might enable it from db
@petmongrels petmongrels self-assigned this Apr 30, 2024
petmongrels added a commit to avniproject/avni-server that referenced this issue May 1, 2024
…n be prompted to handle. handle glific enabled but not configured.
@mahalakshme
Copy link
Contributor Author

username: maha@lahi
env: prerelease
encounter type: LAHI INTERN ATTENDANCE

fails because of incorrect configuration - ve already added the above case in AC above

Also 2nd AC looks like is not implemented - These things will again come via self-service or some other route that it is not evident.

@mahalakshme mahalakshme reopened this Sep 27, 2024
@petmongrels
Copy link
Contributor

@mahalakshme was master server deployed on prerelease to test this?

@mahalakshme
Copy link
Contributor Author

@petmongrels no previously this was part of 10.0. The above is released. I changed it to 10.1, since found the above issues.

If you have done the above, intentionally for some reason, you can let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA Ready
Development

No branches or pull requests

3 participants